feat(repository): add keyFrom to resolved relation metadata#3726
Merged
Conversation
nabdelgadir
force-pushed
the
keyfrom
branch
2 times, most recently
from
September 14, 2019 00:49
62f803e to
d5c73e3
Compare
nabdelgadir
marked this pull request as ready for review
September 14, 2019 01:06
jannyHou
reviewed
Sep 16, 2019
jannyHou
left a comment
jannyHou
left a comment
Contributor
There was a problem hiding this comment.
@nabdelgadir Nice PR to include keyFrom in the metadata. LGTM in general 👍 just left a comment about the type definition.
agnes512
reviewed
Sep 16, 2019
agnes512
left a comment
agnes512
left a comment
Contributor
There was a problem hiding this comment.
Almost looks good to me, I only commented onhasMany since they are similar.
nabdelgadir
force-pushed
the
keyfrom
branch
from
September 16, 2019 17:57
d5c73e3 to
d1613b9
Compare
agnes512
approved these changes
Sep 16, 2019
raymondfeng
approved these changes
Sep 16, 2019
Co-authored-by: Miroslav Bajtoš <mbajtoss@gmail.com>
nabdelgadir
force-pushed
the
keyfrom
branch
from
September 17, 2019 13:13
d1613b9 to
cdede00
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3441.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈